Fix #132 #134
Closed
Fix #132 #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think there's still some useful stuff in here from the standpoint of testability, so a bit later I'll essentially rebase this and resubmit. |
timholy
added a commit
that referenced
this pull request
Mar 10, 2021
"ci" might be a CthulhuInterpreter, CodeInfo, or CallInfo. Use `interp` consistently for CthulhuInterpreter. Also incorporates the test from #134.
Merged
timholy
added a commit
that referenced
this pull request
Mar 10, 2021
"ci" might be a CthulhuInterpreter, CodeInfo, or CallInfo. Use `interp` consistently for CthulhuInterpreter. Also incorporates the test from #134.
timholy
added a commit
that referenced
this pull request
Mar 11, 2021
"ci" might be a CthulhuInterpreter, CodeInfo, or CallInfo. Use `interp` consistently for CthulhuInterpreter. Also incorporates the test from #134.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this adds a more testable call,
do_typeinf,for checking on compiler-related issues.
I'm just guessing that Cthulhu is one of the intended targets of
verbose_stmt_info, so I set the value totrue. Happy to be corrected by those who know more.This passes tests when Julia is compiled at 621ee2aca670e28a7a318b39f5be88d1d9d5fecf, but on nightly it fails due to #133.