Relax to handle qualification

JuliaDebug · Aug 5, 2024 · ab10c89 · ab10c89
1 parent ee3b8c4
commit ab10c89
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/TypedSyntax/src/show.jl b/TypedSyntax/src/show.jl
@@ -95,7 +95,8 @@ function is_show_annotation(@nospecialize(T); type_annotations::Bool, hide_type_
 end
 
 # Is the type equivalent to the source-text?
-is_type_transparent(node, @nospecialize(T)) = replace(sourcetext(node), r"\s" => "") == replace(sprint(show, T), r"\s" => "")
+# We use `endswith` to handle module qualification
+is_type_transparent(node, @nospecialize(T)) = endswith(replace(sprint(show, T), r"\s" => ""), replace(sourcetext(node), r"\s" => ""))
 
 function is_callfunc(node::TypedSyntaxNode, @nospecialize(T))
     pnode = node.parent

diff --git a/TypedSyntax/test/runtests.jl b/TypedSyntax/test/runtests.jl
@@ -620,6 +620,11 @@ include("test_module.jl")
         printstyled(io, obj; hide_type_stable=false)
     end
     @test occursin("::Core.Const(sin)", str) || occursin("::typeof(sin)", str)
+    tsn = TypedSyntaxNode(TSN.calls_helper, (Float32,))
+    str = sprint(tsn; context=:color=>false) do io, obj
+        printstyled(io, obj; hide_type_stable=false)
+    end
+    @test !occursin("Core.Const", str)
 
     # issue #413
     @test TypedSyntax.is_small_union_or_tunion(Union{})

diff --git a/TypedSyntax/test/test_module.jl b/TypedSyntax/test/test_module.jl
@@ -247,4 +247,11 @@ function obfuscated(x)
     return f(x)
 end
 
+module Internal
+export helper
+helper(x) = x+1
+end
+using .Internal
+calls_helper(x) = helper(x)
+
 end