Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prepared queries to ODBC.jl #167

Closed

Conversation

galenlynch
Copy link

This pull request adds the ability to use prepared statements in result returning queries. This required the following changes:

  1. Adding a stmt field to ODBC.Source to allow the use of either a DSN statement pointer or a prepared statement pointer in ODBC.jl functions

  2. Adding a constructor methods to ODBC.Source and ODBC.query that accept prepared statements.

  3. Moving code to bind values to parameters from execute! into its own function, bind_vals!

  4. Moving the code to build a ODBC.Source object from a statement pointer into its own function, build_source

I have additionally added a number of type decorations to methods in Source.jl, as well as splitting some very long lines of code into multi-line statements.

I have updated the documentation to reflect these changes.

@galenlynch
Copy link
Author

The build fails because of this bug in Julia: #22256.

@galenlynch
Copy link
Author

Bump, I think the tests should pass now that the issue in Julia was resolved.

@galenlynch galenlynch closed this Apr 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant