WIP: Add proj keyword to exportcube, to add the CRS #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am trying to add the possibility to add a projection to the data cube. I first wanted to test this with a fixed projection. This would help in using non epsg:4326 projected datacubes, because we can already include them, but the spatial coordinate reference system gets lost in the datacube.
This adds the possibility to add a projection to exportcube. The exportcube function assumes, that you put in a dict with the attributes of the crs. The added projection is only for test purposes and will be removed.
Codecov Report
@@ Coverage Diff @@
## master #124 +/- ##
==========================================
+ Coverage 46.58% 46.63% +0.04%
==========================================
Files 24 24
Lines 2183 2185 +2
==========================================
+ Hits 1017 1019 +2
Misses 1166 1166
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add a proj keyword to the exportcube function, so that the generated netCDF file will have crs information.
I am not happy, that the user would have to add a Dictonary with all of the CRS information, either this should be generated internally from a WKT or Proj string or the CRS information should be included into the metadata of the cube.