Add signed and compress to constructor args #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #48 +/- ##
==========================================
+ Coverage 75.63% 76.23% +0.60%
==========================================
Files 1 1
Lines 197 202 +5
==========================================
+ Hits 149 154 +5
Misses 48 48
Continue to review full report at Codecov.
|
bkamins
reviewed
Jan 29, 2021
| @test eltype(PooledArray(s).refs) == UInt32 | ||
| @test eltype(PooledArray(s, signed=true).refs) == Int32 | ||
| @test eltype(PooledArray(s, compress=true).refs) == UInt8 | ||
| @test eltype(PooledArray(s, signed=true, compress=true).refs) == Int8 |
There was a problem hiding this comment.
can we please add a test when signed widening happens?
bkamins
approved these changes
Jan 29, 2021
bkamins
reviewed
Jan 29, 2021
| @@ -123,13 +126,16 @@ function PooledArray{T}(d::AbstractArray, r::Type{R}) where {T,R<:Integer} | |||
| PooledArray(RefArray(refs::Vector{R}), invpool::Dict{T,R}, pool) | |||
| end | |||
|
|
|||
| function PooledArray{T}(d::AbstractArray) where T | |||
| refs, invpool, pool = _label(d, T) | |||
| function PooledArray{T}(d::AbstractArray; signed::Bool=false, compress::Bool=false) where {T} | |||
There was a problem hiding this comment.
docstring above requires an update about kwargs.
nalimilan
reviewed
Feb 20, 2021
| # Constructor from array, invpool, and ref type | ||
|
|
||
| """ | ||
| PooledArray(array, [reftype]) | ||
| PooledArray(array, [reftype]; signed=false, compress=false) | ||
|
|
||
| Freshly allocate `PooledArray` using the given array as a source where each | ||
| element will be referenced as an integer of the given type. | ||
| If no `reftype` is specified one is chosen automatically based on the number of unique elements. |
There was a problem hiding this comment.
This isn't correct now. See #57.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the discussion in #47 this PR adds keyword arguments
signedandcompressto a constructor.