Skip to content
This repository has been archived by the owner on Jun 4, 2019. It is now read-only.

Replace => syntax with = #16

Merged
merged 1 commit into from
Feb 27, 2017
Merged

Conversation

davidanthoff
Copy link
Collaborator

This implements #12. The old syntax still works but shows a deprecation warning.

@mdcfrancis
Copy link
Contributor

I'm seeing a merge conflict here - is there anything wrong with supporting both the pair interface and the named arg interface ?

@davidanthoff
Copy link
Collaborator Author

If we implement #13, the pair syntax would conflict because @NT(a=>3) should then actually construct a named tuple with one automatically named member of type Pair. We could also implement #13 without support for automatically named members, in wich case I think we could keep the pair syntax around.

Generally it seemed cleaner to me to just have one syntax, and it requires less tests etc. On the other hand, if there is a lot of code out there that uses the pair syntax, it might not be worth breaking... I don't feel strongly about this at all :)

I'll resolve the merge conflict as soon as I have better internet (on a plane right now).

@davidanthoff
Copy link
Collaborator Author

Alright, I rebased.

@davidanthoff
Copy link
Collaborator Author

@mdcfrancis and @JeffBezanson Bump, could we merge this, possibly before we merge #18?

If you don't want the deprecation warning, I'll just take that out for now.

@JeffBezanson
Copy link
Contributor

Yes, I'm in favor.

@mdcfrancis mdcfrancis merged commit 61d8deb into JuliaData:master Feb 27, 2017
@mdcfrancis
Copy link
Contributor

Thanks

@mdcfrancis mdcfrancis mentioned this pull request Feb 27, 2017
@davidanthoff davidanthoff deleted the kw-syntax branch February 27, 2017 17:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants