Don't use Base.Callable #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
======================================
Coverage ? 92%
======================================
Files ? 1
Lines ? 50
Branches ? 0
======================================
Hits ? 46
Misses ? 4
Partials ? 0
Continue to review full report at Codecov.
|
|
I think using |
|
I am OK with this change. |
|
@bkamins Should this be merged then? |
ararslan
reviewed
Aug 30, 2019
ararslan
approved these changes
Aug 30, 2019
|
I propose to wait for @nalimilan to comment on this. After merging all the recent PRs probably we should bump a version of Missings.jl and tag a release. |
it's not exported. i think we can survive without it.
- Better info some cases:
- `typeof(Int) === DataType
- `Core.Typeof(Int) === Type{Int}`
nickrobinson251
force-pushed
the
patch-1
branch
from
009541a
to
ea86178
Compare
bkamins
reviewed
Aug 30, 2019
bkamins
approved these changes
Aug 30, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's not exported. i think we can survive without it.