Update README for Julia 1.0 #98
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
=======================================
+ Coverage 88.46% 92% +3.53%
=======================================
Files 1 1
Lines 52 50 -2
=======================================
Hits 46 46
+ Misses 6 4 -2
Continue to review full report at Codecov.
|
ararslan
reviewed
Jun 27, 2019
| This package still provides additional features to handle `missing` values. | ||
| See [the Julia manual](https://docs.julialang.org/en/v1/manual/missing/index.html) for general documentation on missing values in Julia. | ||
| This package still provides additional features to handle `missing` values: | ||
| - `Missings.T` to extract `T` from a `Union{T, Missing}` type |
There was a problem hiding this comment.
Is it worth mentioning this at all given that Base.nonmissingtype exists?
There was a problem hiding this comment.
Until it's exported I'd rather not recommend it. Also it's broken in complex cases in older Julia versions.
There was a problem hiding this comment.
Suggested change
| - `Missings.T` to extract `T` from a `Union{T, Missing}` type | |
| - `Missings.nonmissingtype` to extract `T` from a `Union{T, Missing}` type |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #97.
We could also add deprecations for remaining functions, but probably better do that for all functions at the same time once replacements have been included in Julia (notably
nonmissingtypeandpassmissing).