Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #52, bad ccall with julia v1.7 #53

Merged
merged 3 commits into from
Jun 30, 2021

Conversation

JeffBezanson
Copy link
Contributor

No description provided.

Copy link
Collaborator

@jpsamaroo jpsamaroo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR!

@jpsamaroo jpsamaroo closed this Jun 30, 2021
@jpsamaroo jpsamaroo reopened this Jun 30, 2021
@jpsamaroo
Copy link
Collaborator

For whatever reason, CI is deciding not to run. It passes tests on 1.8-DEV on Linux, so I'm merging this. Thanks @JeffBezanson for the fix and @vtjnash for the report!

@jpsamaroo jpsamaroo merged commit ad20954 into JuliaData:master Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants