Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new PooledArrays 1.0 release #284

Merged
merged 5 commits into from
Mar 5, 2021
Merged

Support new PooledArrays 1.0 release #284

merged 5 commits into from
Mar 5, 2021

Conversation

quinnj
Copy link
Member

@quinnj quinnj commented Jan 30, 2021

The 1.0 PooledArrays release is non-breaking; just adds new keyword arguments to the PooledArray constructor. Can be merged as long as JuliaRegistries/General#28983 is merged.

@codecov
Copy link

codecov bot commented Jan 30, 2021

Codecov Report

Merging #284 (e41b83a) into main (ab399d5) will increase coverage by 1.50%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #284      +/-   ##
==========================================
+ Coverage   85.93%   87.44%   +1.50%     
==========================================
  Files          15       15              
  Lines        1543     1696     +153     
==========================================
+ Hits         1326     1483     +157     
+ Misses        217      213       -4     
Impacted Files Coverage Δ
src/utils.jl 71.15% <75.00%> (+3.56%) ⬆️
src/reshape.jl 100.00% <0.00%> (ø)
src/flatten.jl 97.03% <0.00%> (+0.16%) ⬆️
src/sortperm.jl 92.10% <0.00%> (+0.43%) ⬆️
src/join.jl 93.76% <0.00%> (+1.16%) ⬆️
src/reduce.jl 89.23% <0.00%> (+1.19%) ⬆️
src/ndsparse.jl 86.82% <0.00%> (+1.20%) ⬆️
src/columns.jl 89.83% <0.00%> (+1.44%) ⬆️
src/indexedtable.jl 80.54% <0.00%> (+1.75%) ⬆️
src/indexing.jl 86.52% <0.00%> (+1.90%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab399d5...dfbb9fc. Read the comment docs.

@quinnj quinnj closed this Jan 31, 2021
@quinnj quinnj reopened this Jan 31, 2021
@quinnj quinnj merged commit c8326a0 into main Mar 5, 2021
@quinnj quinnj deleted the quinnj-patch-1 branch March 5, 2021 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant