add join iterator #283
Merged
add join iterator #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #283 +/- ##
==========================================
+ Coverage 85.76% 85.93% +0.17%
==========================================
Files 15 15
Lines 1510 1543 +33
==========================================
+ Hits 1295 1326 +31
- Misses 215 217 +2
Continue to review full report at Codecov.
|
quinnj
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves an iterator that is only needed in IndexedTables from StructArrays. It is essentially a lazy join done via a merge sort between sorted iterators.
I'm planning to remove it from StructArrays in the next breaking release (see JuliaArrays/StructArrays.jl#166), so I'm making this PR to make the update (from StructArrays 0.4 to 0.5) easier for IndexedTables.
On my machine I get some error during testing about WeakRefStrings, but they seem unrelated. (EDIT: never mind, CI passes here, I must have some dependencies devved locally.)