Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use IndexedTables rather than StructArrays utils #245

Merged
merged 1 commit into from
Apr 25, 2019
Merged

use IndexedTables rather than StructArrays utils #245

merged 1 commit into from
Apr 25, 2019

Conversation

piever
Copy link
Collaborator

@piever piever commented Apr 23, 2019

There already is a foreach in IndexedTables that can do the same job as foreachfield from StructArrays so it's probably safer to not rely on external "utility" functions.

@piever
Copy link
Collaborator Author

piever commented Apr 25, 2019

Better to wait a bit before merging here as foreachfield is actually so useful for StructArrays that I may document it / export it and make it part of the official API, so maybe this change is not needed.

EDIT: in the end I'd rather not commit to exposing foreachfield as part of the API. I'll merge here to further decouple StructArrays and IndexedTables.

@piever piever merged commit e0b10dd into master Apr 25, 2019
@piever piever deleted the pv/clean branch April 25, 2019 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant