Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve names docs #3464

Merged
merged 1 commit into from
Sep 22, 2024
Merged

Improve names docs #3464

merged 1 commit into from
Sep 22, 2024

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Sep 14, 2024

Fixes #3443

@bkamins bkamins added the doc label Sep 14, 2024
@bkamins bkamins added this to the 1.7 milestone Sep 14, 2024
nalimilan
nalimilan approved these changes Sep 22, 2024
View reviewed changes
Copy link
Member

@nalimilan nalimilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but maybe we'd better recommend Symbol.(names(df)) all the time (here and elsewhere) as suggested at #3443?

@bkamins
Copy link
Member Author

bkamins commented Sep 22, 2024

In other cases use of propertynames is more efficient (as Symbol.(names(df)) does conversion Symbol->String->Symbol) and that is why I thought of writing it as is.

Thank you!

@bkamins bkamins merged commit d1d0b54 into main Sep 22, 2024
7 of 8 checks passed
@bkamins bkamins deleted the bk/names_docs branch September 22, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalimilan nalimilan nalimilan approved these changes

@pdeffebach pdeffebach Awaiting requested review from pdeffebach

Assignees
No one assigned
Labels
doc
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

using propertynames on GroupedDataFrame
2 participants
@bkamins @nalimilan