Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TidierData to frameworks docs page #3447

Merged
merged 6 commits into from
Sep 7, 2024
Merged

Add TidierData to frameworks docs page #3447

merged 6 commits into from
Sep 7, 2024

Conversation

drizk1
Copy link
Contributor

@drizk1 drizk1 commented Jul 30, 2024

This PR adds TidierData to the frameworks manipulations docs page.

I tried to keep it brief and similar to the other framework examples.

I am happy to make any changes.

@kdpsingh @bkamins

Thank you

@kdpsingh
Copy link

@drizk1, thanks so much for drafting this. I'll make a few editorial tweaks soon before it's ready for a look by maintainers.

@bkamins
Copy link
Member

bkamins commented Aug 3, 2024

Fix #3446

@bkamins bkamins added the doc label Aug 3, 2024
@bkamins bkamins added this to the 1.7 milestone Aug 3, 2024
@bkamins
Copy link
Member

bkamins commented Aug 3, 2024

@kdpsingh - I will review and merge it after your approval. Thank you!

@kdpsingh
Copy link

kdpsingh commented Aug 3, 2024

Thanks, I'll take a look in the next 2-3 days!

@kdpsingh
Copy link

Sorry for the delay - returning to this soon.

@drizk1
Copy link
Contributor Author

drizk1 commented Sep 4, 2024

@bkamins i have added @kdpsingh edits.

It is ready for your review

Thank you

@kdpsingh
Copy link

kdpsingh commented Sep 4, 2024

Thanks @drizk1. Appreciate your working with me offline. Tried to directly commit my changes to this PR but I am still a bit of a newbie.

@bkamins bkamins merged commit 1761261 into JuliaData:main Sep 7, 2024
4 of 6 checks passed
@bkamins
Copy link
Member

bkamins commented Sep 7, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants