Do not crop columns with type Base.UUID #3347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is failing on Windows, but it does not seem related to this PR. |
bkamins
approved these changes
Jun 25, 2023
bkamins
reviewed
Jun 25, 2023
| maximum_columns_width = Int[truncate == 0 ? 0 : max(truncate + 1, l, textwidth(t)) | ||
| for (l, t) in zip(names_len, types_str)] | ||
|
|
||
| # Apply configurations according to the column's type. | ||
| for i = 1:num_cols | ||
| type_i = nonmissingtype(types[i]) |
There was a problem hiding this comment.
Note that the first condition will be triggered if types[i] is Missing, but probably this is not problematic right?
There was a problem hiding this comment.
Indeed! However, it will not matter because all the lines will have the same size and there will be no dot. So, it will not change anything.
There was a problem hiding this comment.
Yes - that is why I have merged this, but wanted to leave a note if someone came back to this PR. Thanks!
bkamins
approved these changes
Jun 25, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3346