Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add :sum to describe #3303

Merged
merged 4 commits into from
May 11, 2023
Merged

add :sum to describe #3303

merged 4 commits into from
May 11, 2023

Conversation

alecloudenback
Copy link
Contributor

sum total is a useful descriptive statistic for a lot of data analysis and seems as worth as the other built-in options and making desribe more immediately useful for many fields (e.g. finance, economics, demographics, etc).

@bkamins
Copy link
Member

bkamins commented Mar 17, 2023

Looks good apart from :detailed change.

@bkamins
Copy link
Member

bkamins commented Mar 17, 2023

also can you please add NEWS.md entry for 1.6 release (see #3302 how it should look)?

@bkamins bkamins added this to the 1.6 milestone Mar 17, 2023
@alecloudenback
Copy link
Contributor Author

Feedback is incorporated.

@bkamins
Copy link
Member

bkamins commented Apr 28, 2023

Thank you. I updated tests a bit. Once CI passes I will merge the PR.

@bkamins
Copy link
Member

bkamins commented Apr 28, 2023

Approved. Let us wait a few days to see if other maintiners want to comment.

CC @nalimilan

Copy link
Member

@nalimilan nalimilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nalimilan nalimilan merged commit 4ade26f into JuliaData:main May 11, 2023
@alecloudenback alecloudenback deleted the describe_sum branch May 11, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants