Improve examples in the manual in basics.md #3236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalimilan
reviewed
Dec 24, 2022
Comment on lines
412
to
413
| Alternatively you could use a comprehension like this: | ||
| `[a in [1, 5, 601] for a in df.A]`. |
There was a problem hiding this comment.
But this is slower as it recreates the array, right?
There was a problem hiding this comment.
Yes:
julia> length(x)
1000000
julia> @time [a in [1, 5, 601] for a in x];
0.066654 seconds (1.06 M allocations: 80.224 MiB, 10.75% gc time, 32.44% compilation time)
julia> in.(x, Ref([1, 5, 601]));
julia> @time in.(x, Ref([1, 5, 601]));
0.002442 seconds (8 allocations: 126.547 KiB)
julia> @time in([1, 5, 601]).(x);
0.002134 seconds (8 allocations: 126.531 KiB)
I will add this comment.
bkamins
commented
Dec 24, 2022
Co-authored-by: Milan Bouchet-Valat <[email protected]>
nalimilan
approved these changes
Dec 24, 2022
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small improvements based on user feedback