Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make aggregation of empty GroupedDataFrame correct with AsTable #3222

Merged
merged 6 commits into from
Nov 12, 2022

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Nov 9, 2022

Fixes #3217

@bkamins bkamins requested a review from nalimilan November 9, 2022 15:43
@bkamins bkamins added this to the patch milestone Nov 9, 2022
@bkamins bkamins added the bug label Nov 9, 2022
@bkamins
Copy link
Member Author

bkamins commented Nov 9, 2022

CI error on x86 is due to OOM.

@bkamins bkamins linked an issue Nov 9, 2022 that may be closed by this pull request
@bkamins
Copy link
Member Author

bkamins commented Nov 9, 2022

I have also updated documentation which also fixes #3214.

src/groupeddataframe/splitapplycombine.jl Outdated Show resolved Hide resolved
src/groupeddataframe/splitapplycombine.jl Outdated Show resolved Hide resolved
src/groupeddataframe/splitapplycombine.jl Show resolved Hide resolved
@bkamins bkamins merged commit 3935888 into main Nov 12, 2022
@bkamins bkamins deleted the bk/fix_astable branch November 12, 2022 21:52
@bkamins
Copy link
Member Author

bkamins commented Nov 12, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERROR: AssertionError: length(res) > 0 Improve combine documentation
2 participants