add default style to metadata! and colmetadata! #3216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nalimilan: OK to add it to a patch release (the change is that we add |
|
Difficult decision. I guess it's OK to add the default value in a patch release, even if that's not technically a bug fix. |
nalimilan
reviewed
Nov 5, 2022
This is what I thought. We could say that it is a kind of "bug fix", because we become non-compliant with the API we need to follow after DataAPI.jl will be released. On practical terms I doubt someone has code that relies on the fact that e.g. |
nalimilan
approved these changes
Nov 12, 2022
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following JuliaData/DataAPI.jl#56. Should be merged after DataAPI.jl 1.13 release.