Mention DataFrameMacros.jl in the docs #3195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkamins
reviewed
Oct 10, 2022
bkamins
reviewed
Oct 10, 2022
bkamins
reviewed
Oct 10, 2022
bkamins
reviewed
Oct 10, 2022
bkamins
reviewed
Oct 10, 2022
|
Thank you. All is good and thank you for submitting this PR. I have left some minor suggestions. @nalimilan - can you also please look at the wording. |
Co-authored-by: Bogumił Kamiński <[email protected]>
bkamins
approved these changes
Oct 10, 2022
nalimilan
reviewed
Oct 17, 2022
Co-authored-by: Milan Bouchet-Valat <[email protected]>
Co-authored-by: Milan Bouchet-Valat <[email protected]>
nalimilan
approved these changes
Oct 20, 2022
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the two modes of multi-column manipulation, I think this package is again sufficiently different from DataFramesMeta.jl to warrant being mentioned in the DataFrames docs. Otherwise, I think most people will not be able to find it.
I have written "similar to DataFramesMeta" in a couple places, as you know that package came first and there was some cross-pollination back and forth. It seems to me writing "similar" is a shortcut to not repeat the same information again, but if you want to adjust the language, I don't mind. I don't want the text to sound like "similar but better" because it's not a competition and I don't mean it like that.