Sync metadata implementation with DataAPI.jl 1.12.0 #3189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalimilan
approved these changes
Oct 3, 2022
src/other/metadata.jl
Outdated
| end | ||
| emptycolmetadata!(dst) | ||
| DataAPI.colmetadatasupport(typeof(src)).read || return nothing |
There was a problem hiding this comment.
Use an if for consistency with above?
There was a problem hiding this comment.
OK. I have changed short-circut to ifs everywhere then. After CI passes I will merge this PR.
Then I will wait one day to wait for final responses, and will make a release of DataFrames.jl 1.4 tomorrow if there are none.
|
Nice cleanup! |
Co-authored-by: Milan Bouchet-Valat <[email protected]>
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should be passed through CI after JuliaData/DataAPI.jl#53 is merged and DataAPI.jl 1.12.0 is released. Other than that it should be complete (not tested, but the changes are minor - mostly simplification of the code because of dropped default implementations + adding support for
default).