improve names docstring #3178
Merged
improve names docstring #3178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. I'd expect some warnings in the logs if they weren't working, and there doesn't appear to be any. The easiest way to check if the references are working would be by checking the built docs, for which you could set |
|
Thank you! |
nalimilan
approved these changes
Sep 25, 2022
Co-authored-by: Milan Bouchet-Valat <[email protected]>
|
Thank you! |
|
All is OK on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3171
@mortenpi - could you have a quick look if this is correct 😄.
The relevant page in the manual is https://dataframes.juliadata.org/dev/lib/indexing/#General-rules
Thank you!