Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require Julia 1.6 #3145

Merged
merged 6 commits into from
Sep 19, 2022
Merged

Require Julia 1.6 #3145

merged 6 commits into from
Sep 19, 2022

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Sep 13, 2022

Fixes #3136

@bkamins bkamins added the ecosystem Issues in DataFrames.jl ecosystem label Sep 13, 2022
@bkamins bkamins added this to the 1.4 milestone Sep 13, 2022
@bkamins bkamins requested a review from nalimilan September 13, 2022 08:35
@bkamins
Copy link
Member Author

bkamins commented Sep 13, 2022

@nalimilan + @ronisbr :
this PR should not conflict with #3096 and #3055

@bkamins bkamins force-pushed the bk/require_julia_1.6 branch from 0b713a1 to c401ba5 Compare September 18, 2022 08:12
nalimilan
nalimilan reviewed Sep 19, 2022
View reviewed changes
src/DataFrames.jl Outdated Show resolved Hide resolved
src/join/composer.jl Outdated Show resolved Hide resolved
@bkamins
Copy link
Member Author

bkamins commented Sep 19, 2022

Thank you! I will merge it after the metadata PR as it is much smaller.

@bkamins bkamins merged commit 34624f3 into main Sep 19, 2022
@bkamins bkamins deleted the bk/require_julia_1.6 branch September 19, 2022 21:02
@bkamins
Copy link
Member Author

bkamins commented Sep 19, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalimilan nalimilan nalimilan approved these changes

Assignees
No one assigned
Labels
ecosystem Issues in DataFrames.jl ecosystem
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

Require Julia 1.6
2 participants
@bkamins @nalimilan