Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type instability in sort for few columns case and fix issorted bug #2746

Merged
merged 11 commits into from
May 30, 2021
Merged

Fix type instability in sort for few columns case and fix issorted bug #2746

Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ee56676
Fix type instability in sort for few columns case
bkamins May 2, 2021
b9ac3ec
Apply suggestions from code review
bkamins May 2, 2021
607b89b
use recursion
bkamins May 2, 2021
ce18e13
add tests
bkamins May 3, 2021
88a99bc
Update src/other/precompile.jl
bkamins May 3, 2021
9489491
Update src/abstractdataframe/sort.jl
bkamins May 3, 2021
e1241d1
refactor sort to limit recursion and fix bug in issorted
bkamins May 4, 2021
786db70
Update src/abstractdataframe/sort.jl
bkamins May 16, 2021
a16741d
Merge branch 'main' into bkamins-patch-1-1
bkamins May 26, 2021
d53e6ae
add NEWS.md mention
bkamins May 26, 2021
38ffe35
Update NEWS.md
bkamins May 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# DataFrames.jl changes on main since last release notes

## Bug fixes

* fix bug in how `issorted` handles custom orderings and improve performane
bkamins marked this conversation as resolved.
Show resolved Hide resolved
of sorting when complex custom orderings are passed
([#2746](https://github.com/JuliaData/DataFrames.jl/pull/2746))

## Performance improvements

* `SubDataFrame` creation is now more efficient if row selector is
Expand Down