Replace tforeach with @spawn_for_chunks
#2716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It allows keeping the syntax even closer to a normal loop, and it avoids duplicating functionality. Also simplify `@inbounds` uses since it work when put in front of `@spawn_for_chunks`.
bkamins
approved these changes
Apr 12, 2021
|
Looks good. I am OK to merge this when the CI passes. After you merge this PR and #2709 is merged I will generate precompile statements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It allows keeping the syntax even closer to a normal loop,
and it avoids duplicating functionality. Also simplify
@inboundsuses since it work when put in front of
@spawn_for_chunks.I've checked that performance is the same.