Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not use collect in describe #2694

Merged
merged 4 commits into from
Apr 11, 2021
Merged

do not use collect in describe #2694

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7240db1
do not use collect in describe
bkamins Mar 30, 2021
d04ff55
change only the docs
bkamins Mar 30, 2021
bf741b3
do not collect
bkamins Apr 10, 2021
db6cc45
revert docstring change
bkamins Apr 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/abstractdataframe/abstractdataframe.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,9 +522,8 @@ column `:nmissing` will report the number of missing values of that variable.

If custom functions are provided, they are called repeatedly with the vector
corresponding to each column as the only argument. For columns allowing for
missing values, the vector is wrapped in a call to `skipmissing`: custom
functions must therefore support such objects (and not only vectors), and cannot
access missing values.
missing values, the vector is wrapped in a call to `skipmissing` and then
`collect`ed: therefore custom functions cannot access missing values.

# Examples
```julia
Expand Down