-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix repeat and some other minor issues #2648
Conversation
Actually maybe |
As commented above - I have thought about it and I think that we should accept |
test/subdataframe.jl
Outdated
if VERSION > v"1.6" | ||
@test_throws ArgumentError SubDataFrame(sdf, Integer[true, true, true], :) | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And what happens before 1.6? :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before (and including 1.6) 1.7 it works - see the old test that got removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, shouldn't this be tested too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK - I have reverted it (although it was kept mainly to keep track of the bug in Julia Base).
A follow up PR in Julia Base that should be fixed is JuliaLang/julia#39962 (I am pinging you as it seem no one commented on it).
Some fixes after JuliaLang/julia#31829.
Mainly restricting the signature of
repeat
.Additionally one dangling
get
tounwrap
for CategoricalArrays.jl compatibility I missed earlier.@mbauman
The JuliaLang/julia#31829 broke the following thing in Julia Base that was not covered by tests (fortunately we had appropriate tests in DataFrames.jl):