Add faster semi and antijoin #2641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Milan Bouchet-Valat <[email protected]>
|
I have refactored the code following your suggestions. The code is now faster in some specific cases (as I was able to switch from CI fails because of breaking changes in 1.7. I will fix it in separate PRs. |
nalimilan
approved these changes
Mar 8, 2021
Co-authored-by: Milan Bouchet-Valat <[email protected]>
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2340
This is the last PR for making joins faster.
Here are the benchmarks against 0.22.5 release. As before we are either much faster or comparable.
semi_022_5.txt
semi_pr.txt
The only small problem is code duplication. I would prefer to avoid it, but first I wanted to make sure we have thing correct and fast. The problem is that duplicate methods get different arguments and are minimally different (in other words: we use exactly the same high level logic, but collect and pass around different information as the resulting join is different since it involves only left table).