Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DataFrame(Any[]) test #2609

Merged
merged 1 commit into from
Jan 23, 2021
Merged

Fix DataFrame(Any[]) test #2609

merged 1 commit into from
Jan 23, 2021

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Jan 23, 2021

@quinnj - I guess it is intended in Tables.jl 1.3.1 change?

Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bkamins bkamins merged commit 8e207f4 into main Jan 23, 2021
@bkamins bkamins deleted the bkamins-patch-1 branch January 23, 2021 17:46
@bkamins
Copy link
Member Author

bkamins commented Jan 23, 2021

Thank you!

@strickek
Copy link

strickek commented Apr 3, 2021

@bkamins - I have a test error (current Julia installation 1.6.0) because this commit is in master, but not part of the actual release v0.22.7. Is this intended or an oversight?

@bkamins
Copy link
Member Author

bkamins commented Apr 3, 2021

Yes - this commit is in main, but it was not backported, as it only fixes tests and has no effect on the functionality. Why do you need 0.22.7 tests to pass? (if we make 0.22.8 release I will backport it)

@strickek
Copy link

strickek commented Apr 4, 2021

no need. I just tested the few packages I use regularly after installing Julia 1.6.0. and was not sure about.

@bkamins
Copy link
Member Author

bkamins commented Apr 4, 2021

OK - thank you for reporting then. It is really appreciated.

This test fails because Tables.jl version changed underneath. On main all works correctly.

PS. We regularly have a similar issue with Julia Base 😄, as tests in DataFrames.jl are extensive, so if something changes in Julia usually DataFrames.jl tests start to fail. We keep track of this, but do not make release for every test that has to be updated as this is not something exposed to the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants