CompatHelper: bump compat for "Reexport" to "1.0" #2587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
@ararslan - I understand it is safe to merge it once https://github.com/simonster/Reexport.jl is tagged. Right? |
bkamins
added
backport
ecosystem
|
Any idea why CI doesn't run? |
|
I do not know - it happened sometimes in the past also, but I do not know the rule here. |
|
Closing and reopening works. Unfortunately, CI used 0.2.0 because of dependencies, so we shouldn't merge this for now. |
ararslan
approved these changes
Jan 4, 2021
Pkg doesn't care about git tags, so as long as 1.0 is in the registry (which it seems to be given that this PR was opened) then it's safe. |
|
(I just made a tag anyway) |
bkamins
deleted the
compathelper/new_version/2020-12-26-00-36-20-165-2050621716
branch
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
Reexportpackage from0.1, 0.2to0.1, 0.2, 1.0.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.