error when using one dimension for indexing #2553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalimilan
reviewed
Nov 20, 2020
nalimilan
approved these changes
Nov 20, 2020
bkamins
changed the title
|
@pdeffebach - are you OK with this? After I merge this PR I am going to make a patch release. |
pdeffebach
approved these changes
Nov 20, 2020
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was asked for by @nalimilan and @pdeffebach.
I think we should be restrictive and cover only the most common cases. I was also unsure how to best formulate the error (and let us hope these definitions do not run into method ambiguities, because we use
AbstractDataFramein both, andAnyin the second one). It seems they are OK.The only change is that we throw
ArgumentErrornotMethodErrorbut it is considered non-breaking.