Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #2550 fix two small typos in docs #2551

Merged
merged 4 commits into from
Nov 19, 2020

Conversation

roualdes
Copy link
Contributor

Fixes issue #2550.

I looked through the contributor's guide, but didn't see anything about local testing before submitting a PR. Please let me know if there is documentation that I missed and should follow. Thanks.

@bkamins bkamins linked an issue Nov 19, 2020 that may be closed by this pull request
@bkamins bkamins added the doc label Nov 19, 2020
@bkamins bkamins added this to the 1.x milestone Nov 19, 2020
docs/src/lib/types.md Outdated Show resolved Hide resolved
@bkamins
Copy link
Member

bkamins commented Nov 19, 2020

Thank you. While we are at it could you also fix https://github.com/JuliaData/DataFrames.jl/blob/master/src/abstractdataframe/selection.jl#L47 as there is the same error there.

@bkamins bkamins merged commit bb1362e into JuliaData:master Nov 19, 2020
@bkamins
Copy link
Member

bkamins commented Nov 19, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Two small typos in docs
2 participants