Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subset #2496
Add subset #2496
Changes from 11 commits
4342310
be7c506
6c4cf8c
d614e55
1859935
8dc5620
fe29da1
33966df
48cc618
1c28639
9655daf
058c06e
2ae30ca
2f7a919
1e481c6
e43afb5
6704541
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't have to be implemented right now, but I guess at some point it will make sense to support
ungroup=false
to get aGroupedDataFrame
like withselect
/transform
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what I had in an initial implementation. Then I thought that the problem is that
ungroup=false
does not give us any benefit (as inselect
/transform
as we have to rungroupby
anyway) and complicates the API. But given you raised it I think it is OK to have it for consistency. I will add it back.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could apply the grouping code directly to group indices, using the same path as
refarray
/refpool
. It could often be faster than using the original columns. Maybe leave a TODO?