Use skipmissing() instead of Missings.skip() #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latter is deprecated.
nalimilan
force-pushed
the
nl/skipmissing
branch
from
eec71a8 to
0e65d03
Compare
ararslan
approved these changes
Nov 23, 2017
nalimilan
commented
Nov 24, 2017
| julia> Missings.skip(x) | ||
| Base.Generator{Base.Iterators.Filter{Missings.##4#6,Array{Union{Int64, Missings.Missing},1}},Missings.##3#5}(Missings.#3, Base.Iterators.Filter{Missings.##4#6,Array{Union{Int64, Missings.Missing},1}}(Missings.#4, Union{Int64, Missings.Missing}[1, 2, missing])) | ||
| julia> skipmissing(x) | ||
| Missings.EachSkipMissing{Array{Union{$Int, Missings.Missing},1}}(Union{$Int, Missings.Missing}[1, 2, missing]) |
There was a problem hiding this comment.
Looking at the online manual, it doesn't look like $Int was correct here.
@cjprybol Do you know how we're supposed to handle this kind of situation?
There was a problem hiding this comment.
The $Int is necessary to get tests to pass on 32 & 64 bit, but it won't work because the $Int is within the triple-backtick code block? Is that the issue?
|
Yes. Do you know of any solution? |
|
I don't offhand, but I'll see if I can find one |
|
Couldn't think of anything better than just switching the tests to Floats, but I guess that'll do the job, right? See #1299 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latter is deprecated.