Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag a release containing #2656 to fix combine on Arrow-backed DataFrames? #2689

Closed
jrevels opened this issue Mar 30, 2021 · 5 comments
Closed
Labels

Comments

@jrevels
Copy link

jrevels commented Mar 30, 2021

👋

I have a downstream CI breakage that appears to be fixed by this PR - would it be possible to get a new release tagged with this fix :)

Thanks!

@bkamins
Copy link
Member

bkamins commented Mar 30, 2021

I do not think #2682 should fix anything in the package (what it only does is throwing an error in cases when earlier we allow some aggregations that are non-standard; of course I might be wrong). You could use git bisect to locate the actual commit that fixes your issue then we can analyze if it can be backported. However, I expect to have 1.0 release of DataFrames.jl in a few weeks, so maybe it is enough for you to wait and just use main temporarily?

@jrevels jrevels changed the title tag a release containing https://github.com/JuliaData/DataFrames.jl/pull/2682? tag a release containing #2656 to fix combine on Arrow-backed DataFrames? Mar 31, 2021
@jrevels
Copy link
Author

jrevels commented Mar 31, 2021

Good call, I was making a (poor) guess based on the stacktrace and most recent git blame in that file.

Looks like the commit that actually solves my problem is 140a3e0 (xref #2656).

It seems this commit cherry-picks nicely onto v0.22_patches without conflicts - is that where new releases are tagged from at the moment? If I opened a PR to that branch that cherry-picks that commit + bumps the Project.toml to v0.22.7, would that be something we could merge/tag? Happy to do so if that's sufficient 🙂

IMO since this affects any DataFrames + Arrow 1.3 users it seems worthwhile to backport soon if it's easy to do so

jrevels added a commit to beacon-biosignals/Onda.jl that referenced this issue Mar 31, 2021
jrevels added a commit to beacon-biosignals/Onda.jl that referenced this issue Mar 31, 2021
@bkamins
Copy link
Member

bkamins commented Mar 31, 2021

I am OK to cherry-pick #2656 and make a patch release.

I can do it today if @nalimilan approves.

@bkamins
Copy link
Member

bkamins commented Mar 31, 2021

Release done:
8ce6f5f#commitcomment-48933330

@bkamins bkamins closed this as completed Mar 31, 2021
@jrevels
Copy link
Author

jrevels commented Mar 31, 2021

Woohoo, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants