-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tag a release containing #2656 to fix combine
on Arrow-backed DataFrames?
#2689
Comments
I do not think #2682 should fix anything in the package (what it only does is throwing an error in cases when earlier we allow some aggregations that are non-standard; of course I might be wrong). You could use git bisect to locate the actual commit that fixes your issue then we can analyze if it can be backported. However, I expect to have 1.0 release of DataFrames.jl in a few weeks, so maybe it is enough for you to wait and just use |
combine
on Arrow-backed DataFrames?
Good call, I was making a (poor) guess based on the stacktrace and most recent git blame in that file. Looks like the commit that actually solves my problem is 140a3e0 (xref #2656). It seems this commit cherry-picks nicely onto IMO since this affects any DataFrames + Arrow 1.3 users it seems worthwhile to backport soon if it's easy to do so |
I am OK to cherry-pick #2656 and make a patch release. I can do it today if @nalimilan approves. |
Release done: |
Woohoo, thanks! |
👋
I have a downstream CI breakage that appears to be fixed by this PR - would it be possible to get a new release tagged with this fix :)
Thanks!
The text was updated successfully, but these errors were encountered: