Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add filter example to docs on taking subsets #2318

Closed
floswald opened this issue Jul 17, 2020 · 2 comments
Closed

add filter example to docs on taking subsets #2318

floswald opened this issue Jul 17, 2020 · 2 comments
Labels
doc

Comments

@floswald
Copy link
Contributor

hey,
just learned on twitter and https://bkamins.github.io/julialang/2020/07/17/pair.html that I can filter on an entire dataframe. blew my mind ! i think should be added to the docs in the taking a subset section.
@bkamins bkamins added the doc label Jul 17, 2020
@bkamins
Copy link
Member

bkamins commented Jul 17, 2020

Indeed we could add a documentation to filter and filter! with both predicate and cols => predicate as a first argument (the => style is faster and often more terse).

If you feel like it - please open a PR with some examples that you would consider instructive (if not - then let me know and I will propose something).

floswald added a commit to floswald/DataFrames.jl that referenced this issue Jul 24, 2020
@floswald
proposal for JuliaData#2318
71143f3
@floswald floswald mentioned this issue Jul 24, 2020
Closed
@bkamins bkamins linked a pull request Jul 24, 2020 that will close this issue
add filter example to docs on taking subsets #2327
Closed
floswald added a commit to floswald/DataFrames.jl that referenced this issue Oct 1, 2020
@floswald
proposal for JuliaData#2318
77f82c6
floswald added a commit to floswald/DataFrames.jl that referenced this issue Jan 11, 2021
@floswald
proposal for JuliaData#2318
442d02b
@bkamins
Copy link
Member

bkamins commented Dec 4, 2022

the documentation in that section was updated.

@bkamins bkamins closed this as completed Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add filter example to docs on taking subsets floswald/DataFrames.jl
2 participants
@floswald @bkamins