Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history 
Co-authored-by: Milan Bouchet-Valat <[email protected]>
  • Loading branch information
@bkamins @nalimilan
bkamins and nalimilan committed Sep 22, 2024
1 parent 1145ad7 commit 85815e4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions docs/src/man/working_with_dataframes.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -891,8 +891,8 @@ julia> combine(df2, All() .=> identity .=> c -> first(c) .* ["_min", "_max"])
1 │ 1 4 1.0 4.0
```

Note that in this example we needed to pass `identity` explicitly as with
`All() => (c -> first(c) .* ["_min", "_max"])` the right-hand side part would be
Note that in this example we needed to pass `identity` explicitly since with
`All() => (c -> first(c) .* ["_min", "_max"])` the right-hand side part would be
treated as a transformation and not as a rule for target column names generation.

You might want to perform the transformation of the source data frame into the result
Expand Down

2 comments on commit 85815e4

@bkamins
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/115786

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v1.7.0 -m "<description of version>" 85815e45c559aae14a194f913e25df0e484248bd
git push origin v1.7.0

Please sign in to comment.