Add optimized method for collect(::SkipMissing{<: CatArrOrSub}} #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fallback method is currently extremely slow as it checks that the destination pool is a superset of the source pool for each entry. This optimization would be faster anyway even if we fixed that.
nalimilan
force-pushed
the
nl/skipmissing
branch
from
8f4b759 to
418b12c
Compare
bkamins
reviewed
Mar 31, 2021
src/array.jl
Outdated
| # Defined for performance | ||
| function collect(x::Base.SkipMissing{<: CatArrOrSub{T}}) where {T} | ||
| r = refs(x.x) | ||
| return CategoricalVector{T}(r[r .> 0], copy(pool(x.x))) |
There was a problem hiding this comment.
this code is incorrect for 0-dimensional arrays or views:
julia> y = categorical(fill("a"))
0-dimensional CategoricalArrays.CategoricalArray{String,0,UInt32}:
"a"
julia> y[y.refs .> 0]
ERROR: ArgumentError: invalid index: true of type Bool
you have to special case this scenario. Other than that it looks good.
There was a problem hiding this comment.
Good catch. I think filter should work in all cases, right?
I also realized I forgot to call nonmissingtype.
|
Printing tests need to be updated to pass on Julia 1.6. |
bkamins
approved these changes
Mar 31, 2021
nalimilan
added a commit
that referenced
this pull request
Mar 31, 2021
The fallback method is currently extremely slow as it checks that the destination pool is a superset of the source pool for each entry. This optimization would be faster anyway even if we fixed that.
|
Backported to 0.9.4: JuliaRegistries/General#33246 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fallback method is currently extremely slow as it checks that the destination pool is a superset of the source pool for each entry. This optimization would be faster anyway even if we fixed that.
Fixes JuliaData/DataFrames.jl#2693.