Allow more permissive string parsing #973
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set the value if we have `valueok` rather than relying on `!invalid`, to avoid erroring when we have successfully parsed a string but then hit an invalid delimiter. - Fixes JuliaData#972.
nickrobinson251
force-pushed
the
npr/972
branch
from
edc711c to
f006077
Compare
|
aaaand this changes breaks a bunch of other cases 😆 i will keep investigating for a better fix (or Jacob might immediately just see what's up) |
nickrobinson251
force-pushed
the
npr/972
branch
from
c18967c to
55ed9df
Compare
|
maybe just not needed 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
valueokratherthan relying on
!invalid, to avoid erroringwhen we have successfully parsed a string but
then hit an invalid delimiter.
I don't actually see why
"Data from A.-M. Guerry, \"Essay on the Moral Statistics of France\""is getting parsed only asData from A.-M. Guerry,, but it is even with prior versions of CSV (e.g. v0.8) and Parsers (e.g. v1), so this PR just restores the behaviour we had with Parsers v2.2.0, but which broke when we started marking such cases as invalid in Parsers v2.2.1cc @quinnj @andreasnoack