A little refactoring to improve inference and precompilation #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes in files that are not precompile.jl are inference improvements; mainly from inspecting results of `@code_typed`, Cthulhu.jl, and SnoopCompile.jl. The changes in precompile.jl are from comments from @timholy recommending that in our precompile process, we can just call regular code instead needing to call `precompile` with methods/arg types. I'm aware I don't understand all the details around precompilation, method invalidation, etc. but unfortunately, I feel a bit blocked with CSV.jl's precompilation. With the changes in #875, we now see a fixed overhead of allocations when parsing due, I'm told, to an issue in Base Julia (JuliaLang/julia#34055).
Codecov Report
@@ Coverage Diff @@
## main #880 +/- ##
==========================================
+ Coverage 88.92% 89.76% +0.84%
==========================================
Files 9 9
Lines 2113 2111 -2
==========================================
+ Hits 1879 1895 +16
+ Misses 234 216 -18
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in files that are not precompile.jl are inference
improvements; mainly from inspecting results of
@code_typed,Cthulhu.jl, and SnoopCompile.jl. The changes in precompile.jl are from
comments from @timholy recommending that in our precompile process, we
can just call regular code instead needing to call
precompilewithmethods/arg types. I'm aware I don't understand all the details around
precompilation, method invalidation, etc. but unfortunately, I feel a
bit blocked with CSV.jl's precompilation. With the changes in #875, we
now see a fixed overhead of allocations when parsing due, I'm told, to
an issue in Base Julia
(JuliaLang/julia#34055).