Allow turning off missing value parsing #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #768. We can potentially allow passing `missingstring` per column, but that seems like a more rare need than turning off missing value parsing all together, which allows string columns to parse empty strings correctly by default. The reason per column isn't quite as compelling is that you can already pass a vector of missing string values to `missingstring` to check any of the values for `missing`. So it would only be the use-case of wanting to parse a missing string in one column _but not_ another where per-column missing strings would be useful.
Codecov Report
@@ Coverage Diff @@
## main #865 +/- ##
=======================================
Coverage 90.88% 90.88%
=======================================
Files 9 9
Lines 1898 1898
=======================================
Hits 1725 1725
Misses 173 173
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #768. We can potentially allow passing
missingstringper column,but that seems like a more rare need than turning off missing value
parsing all together, which allows string columns to parse empty strings
correctly by default. The reason per column isn't quite as compelling is
that you can already pass a vector of missing string values to
missingstringto check any of the values formissing. So it wouldonly be the use-case of wanting to parse a missing string in one column
but not another where per-column missing strings would be useful.