Fix ByteValueCounter out of bounds indexing #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #845. The issue here is we were incrementing the ByteValueCounter counts vector using the byte value itself, which obviously was out of bounds for the null character `'\0'`. The solution is pretty simple: just increment the indexing to ensure we're always inbounds.
Codecov Report
@@ Coverage Diff @@
## main #847 +/- ##
=======================================
Coverage 90.84% 90.84%
=======================================
Files 9 9
Lines 1845 1845
=======================================
Hits 1676 1676
Misses 169 169
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #845. The issue here is we were incrementing the ByteValueCounter
counts vector using the byte value itself, which obviously was out of
bounds for the null character
'\0'. The solution is pretty simple:just increment the indexing to ensure we're always inbounds.