Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax type constraints on filenames #394

Closed
wants to merge 1 commit into from

Conversation

oxinabox
Copy link

To allow this to work with FilePathBase file types.
Which no longer subtype AbstractString (rofinn/FilePathsBase.jl#22)

This change basically says tht if you don't give it a IO object,
then whatever you do give it must have an open method.

@codecov
Copy link

codecov bot commented Mar 26, 2019

Codecov Report

Merging #394 into master will decrease coverage by 13.19%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #394      +/-   ##
==========================================
- Coverage   76.25%   63.05%   -13.2%     
==========================================
  Files           8        8              
  Lines        1040     1053      +13     
==========================================
- Hits          793      664     -129     
- Misses        247      389     +142
Impacted Files Coverage Δ
src/CSV.jl 69.15% <66.66%> (-7.7%) ⬇️
src/tables.jl 65.09% <0%> (-27.22%) ⬇️
src/transforms.jl 48.57% <0%> (-16.95%) ⬇️
src/write.jl 80.85% <0%> (-15.96%) ⬇️
src/filedetection.jl 66.66% <0%> (-13.23%) ⬇️
src/deprecated.jl 48.16% <0%> (-11.15%) ⬇️
src/typedetection.jl 83.33% <0%> (-9.17%) ⬇️
src/validate.jl 90% <0%> (-5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8ef8f9...ec887b5. Read the comment docs.

@quinnj
Copy link
Member

quinnj commented Apr 29, 2019

Closing in favor of #405

@quinnj quinnj closed this Apr 29, 2019
@oxinabox oxinabox mentioned this pull request Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants