implement syncscopes everywhere #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
force-pushed
the
vc/syncscope
branch
from
ce6addc to
0217a90
Compare
vchuravy
force-pushed
the
vc/syncscope
branch
from
0217a90 to
828833a
Compare
vchuravy
commented
Dec 6, 2024
| @@ -45,4 +47,8 @@ const seq_cst = Internal.seq_cst | |||
| const acquire_release = acq_rel | |||
| const sequentially_consistent = seq_cst | |||
|
|
|||
| # SyncScope | |||
| const none = Internal.none | |||
There was a problem hiding this comment.
Should we have an alias for this called system?
|
@maleadt so the last remaining question is what do we do about the GPU backend specific syncscopes.
|
|
What about leaving it up to the caller and simply using symbols? I'm not sure how we'll be able to generalize this without some input from the back-end anyway (i.e. Metal.jl specifying which syncscope to use for a certain kind of array). |
|
Yeah, right now, I allow for anything to be wrapped in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO