Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for passing synchronization scopes #17

Closed
maleadt opened this issue Nov 28, 2024 · 3 comments
Closed

Support for passing synchronization scopes #17

maleadt opened this issue Nov 28, 2024 · 3 comments

Comments

@maleadt
Copy link
Member

maleadt commented Nov 28, 2024

Currently, only LLVM.Internal.atomic_pointermodify takes a syncscope argument; probably all UnsafeAtomics APIs do.

@pxl-th How are you setting custom syncscopes?
@pxl-th
Copy link
Contributor

pxl-th commented Nov 28, 2024

At the moment I'm just setting syncscope to agent for all FP +- atomic ops:
https://github.com/JuliaGPU/AMDGPU.jl/blob/57d8324533209b456e789897c18a10b021afc090/src/AMDGPU.jl#L149

@vchuravy
Copy link
Member

After #20 we can now do UnsafeAtomics.modify!(ptr, op, x, ord, UnsafeAtomics.Internal.LLVMSyncScope{:agent}())

@vchuravy
Copy link
Member

JuliaGPU/AMDGPU.jl#709

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vchuravy @maleadt @pxl-th