Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added oneAPI extension and buildkite CI #43

Merged
merged 12 commits into from
Nov 25, 2024
Merged

Conversation

anicusan
Copy link
Contributor

This is almost verbatim from the extensions refactor.
With this, we should now have atomics on all AcceleratedKernels.jl backends, yay!

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 31 lines in your changes missing coverage. Please review.

Project coverage is 60.16%. Comparing base (e60c518) to head (873e7b6).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
ext/AtomixoneAPIExt.jl 0.00% 31 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #43       +/-   ##
===========================================
- Coverage   92.95%   60.16%   -32.79%     
===========================================
  Files           6        9        +3     
  Lines         142      236       +94     
===========================================
+ Hits          132      142       +10     
- Misses         10       94       +84     
Flag Coverage Δ
Pkg.test 60.16% <0.00%> (-32.79%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

… will then need to be updated around the ecosystem
@anicusan
Copy link
Contributor Author

Okay, all backend extensions are found and their tests work when temporarily setting Atomix version=0.1.0 so that all packages can be downloaded (otherwise dependency conflicts appear).

@maleadt I updated to version=1.0.0 like you did the first time in the initial pull request.

Any other feedback is very welcome.

Project.toml Outdated Show resolved Hide resolved
Remove oneAPI from deps, as it was in weakdeps already

Co-authored-by: Christian Guinard <[email protected]>
@maleadt maleadt merged commit aaefe62 into JuliaConcurrent:main Nov 25, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants