Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: option to fix canonical URLs of a multidocumenter build #60

Merged
merged 5 commits into from
Aug 25, 2023

Conversation

mortenpi
Copy link
Member

WIP. Adds the canonical option to make (so set the root of the canonical URL), and fix_canonical_url option to MultiDocRef to opt out from generating the canonical URLs for specific docs.

Adds DocumenterTools as a dependency and currently depends on JuliaDocs/DocumenterTools.jl#78. But maybe we should put all the code here for now, get some real world testing, and then later move the general functions into DocumenterTools, before committing to specific behaviors there.

@mortenpi mortenpi marked this pull request as ready for review August 24, 2023 06:15
@pfitzseb pfitzseb self-requested a review August 24, 2023 07:40
src/documentertools/walkdocs.jl Show resolved Hide resolved
@mortenpi mortenpi requested a review from pfitzseb August 25, 2023 08:05
@pfitzseb pfitzseb merged commit afa5a76 into main Aug 25, 2023
@delete-merged-branch delete-merged-branch bot deleted the mp/canonical branch August 25, 2023 08:33
@mortenpi mortenpi restored the mp/canonical branch November 9, 2023 06:13
@mortenpi mortenpi deleted the mp/canonical branch November 9, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants