More AbstractDict interface and reduce invalidations/ambiguities #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enforces the key to be `Symbol` or `String`, which are the only
types compatible with dot access anyway. It also allows us to combine
a lot of code by using `_tokey(::PropertyDicts{K}, key)` to clearly
convert `key` to the appropriate type.
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
===========================================
- Coverage 100.00% 99.15% -0.85%
===========================================
Files 1 1
Lines 71 118 +47
===========================================
+ Hits 71 117 +46
- Misses 0 1 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Biggest improvements to interface were support for
mergeandmergewith. This required conditionally overloading some methods not defined in Base, but using the@staticmacro should prevent any issues there.We were previously allowing any key type while internally converting between
StringandSymbol. The table and DataFrames community have learned that avoiding ambiguities with interchangeableSymbolandStringkeys takes some more explicit annotations (don't have an issue bit this comment mentions it). So we explicitly enforce that change in the type here. I don't think this breaks anyone's code but I think it is technically a breaking change, so I'm doing a v0.2 release on this one.