This repository has been archived by the owner on Sep 1, 2020. It is now read-only.
Length fixes (#100 and a fix for 0.6) #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
==========================================
+ Coverage 94.11% 94.42% +0.31%
==========================================
Files 1 1
Lines 374 377 +3
==========================================
+ Hits 352 356 +4
+ Misses 22 21 -1
Continue to review full report at Codecov.
|
|
Proposal: after this, we make a patch release representing the last release supporting 0.4, then drop support for 0.4 in order to simplify a lot of code and enable us to work on some of the existing ideas in issues/PRs more easily. |
ararslan
reviewed
Apr 5, 2017
src/Iterators.jl
Outdated
| return true | ||
| else | ||
| return false | ||
| end |
There was a problem hiding this comment.
return isa(it_size, HasLength) || isa(it_size, HasShape)?
There was a problem hiding this comment.
Hah, maybe I should have waited until tomorrow to submit!
I'll change that with a rebase.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#100 Fix
On 0.5 and up, checking for
HasLength() || HasShape()is the right way to handle checking whether it is safe to calllength. On 0.4iteratorsizedoesn't exist, soapplicable(lengthis our fallback.0.6 Fix
Since the 265 solution in Julia, generated function methods are only aware of methods that existed when they were compiled. Moving
_chain_isto the bottom makes it work for all cases involvingiteratorsizein Base and Iterators, but the way forward involves getting rid of generated functions I think.