-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added properties and propertyvalues iterators #61
Conversation
Can you post the benchmark comparisons here for future reference? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, please add docs now :)
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
==========================================
- Coverage 66.66% 65.31% -1.36%
==========================================
Files 1 1
Lines 246 222 -24
==========================================
- Hits 164 145 -19
+ Misses 82 77 -5
Continue to review full report at Codecov.
|
Please add the docstrings to docs/src/index.md |
This is pretty similar to #46 and has similar performance characteristics (e.g., faster with mixed value types at the cost of being slower when the value types are all the same).